-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruff for quality checking #362
Comments
Sorry, responded from a work account before. 100% open to a pr on this. I don't typically add features to diff cover myself since I don't actively work on any python projects right now and I would prefer anything that gets added has at least one person who intends on using the feature. I see my role as maintaining dependencies, keeping python up to date, managing prs that come in and helping with issues when there is enough detail for me to understand and reproduce the problem. |
I would also like to see this feature developed, I definitely find it useful since ruff is like the all-around linter |
My team switched to ruff an year ago, ~4 months later we removed flake8 and later we reduces our use of pylint and pydocstyle gradually as each new version of ruff covered extra checks done by these. At some point we will likely remove pylint and pydocstyle too. -- we use pre-commit hooks to orchestrate running these. PS. We already started to use ruff reformatting, but we run black after it too to cover for the very few cases where these diverge. |
Ruff seems to be the cool new kid on the block for Python linting. Could we have diff-cover support it for quality checking? At a quick look I guess it might be pretty simple if it works nicely with
RegexBasedDriver
, if I get time to try it myself I will do...The text was updated successfully, but these errors were encountered: