You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't want to "push" the need for a "tox.ini" file, but I was surprised to discover that this package does not use any python test orchestrator. Tox is the most popular but other alternatives like nox are also acceptable.
Why? I discovered that diff_cover was not working well with py313 and didn't even have a github pipeline testing it. While trying to make a PR to enable it I found that there is no way to test it locally without involving a lot of manual venv setups, which clearly would make local vs CI testing diverge even more.
The text was updated successfully, but these errors were encountered:
In fact while raising the PR, I discovered another problem which discourage contributing: CI does not run without approval. Anyway, this once is easy to fix in repo settings.
Its not clear to me what manual steps are required. You should be able to just follow the same steps as the github workflow. Install python, install poetry, run poetry install, run verify.sh
I don't want to "push" the need for a "tox.ini" file, but I was surprised to discover that this package does not use any python test orchestrator. Tox is the most popular but other alternatives like nox are also acceptable.
Why? I discovered that diff_cover was not working well with py313 and didn't even have a github pipeline testing it. While trying to make a PR to enable it I found that there is no way to test it locally without involving a lot of manual venv setups, which clearly would make local vs CI testing diverge even more.
The text was updated successfully, but these errors were encountered: