Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not easy to test the diff_cover locally #426

Open
ssbarnea opened this issue Dec 10, 2024 · 2 comments
Open

Not easy to test the diff_cover locally #426

ssbarnea opened this issue Dec 10, 2024 · 2 comments

Comments

@ssbarnea
Copy link
Contributor

I don't want to "push" the need for a "tox.ini" file, but I was surprised to discover that this package does not use any python test orchestrator. Tox is the most popular but other alternatives like nox are also acceptable.

Why? I discovered that diff_cover was not working well with py313 and didn't even have a github pipeline testing it. While trying to make a PR to enable it I found that there is no way to test it locally without involving a lot of manual venv setups, which clearly would make local vs CI testing diverge even more.

@ssbarnea
Copy link
Contributor Author

In fact while raising the PR, I discovered another problem which discourage contributing: CI does not run without approval. Anyway, this once is easy to fix in repo settings.

@Bachmann1234
Copy link
Owner

Its not clear to me what manual steps are required. You should be able to just follow the same steps as the github workflow. Install python, install poetry, run poetry install, run verify.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants