You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! We have PR where we only removed some lines of code, and no lines were added or changed. The file does not have good coverage and was written way before diff-cover was introduced into our CI, but it looks like it was detected as an uncovered and failed pipeline.
Do you know if this behavior is intended? IMO, when devs remove a bunch of code during refactoring in aged repos, it's not fair to ask them to cover all files uncovered before him just for deletion. But I understand an entirely valid point about failing the lint in cases where some lines were added or changed.
Also, is there any workaround to skip the linter using any keywords in the commit message?
The text was updated successfully, but these errors were encountered:
alexandre-orca
changed the title
Failing on file where all changes are removal
Failing on file where all changes are lines removal
Jan 27, 2025
Hi! We have PR where we only removed some lines of code, and no lines were added or changed. The file does not have good coverage and was written way before
diff-cover
was introduced into our CI, but it looks like it was detected as an uncovered and failed pipeline.Do you know if this behavior is intended? IMO, when devs remove a bunch of code during refactoring in aged repos, it's not fair to ask them to cover all files uncovered before him just for deletion. But I understand an entirely valid point about failing the lint in cases where some lines were added or changed.
Also, is there any workaround to skip the linter using any keywords in the commit message?
The text was updated successfully, but these errors were encountered: