From 855d9ca29e87f206135503498dead5f6c6261f23 Mon Sep 17 00:00:00 2001
From: Martin Kang <martin@betterment.com>
Date: Tue, 2 Feb 2021 17:40:34 -0500
Subject: [PATCH] Change default http_open_timeout to 2 seconds (from 15
 seconds) (#17)

* change default http_open_timeout to 2 seconds (from 15 seconds)

* bump minor version
---
 README.md                              | 2 +-
 lib/journaled.rb                       | 2 +-
 lib/journaled/version.rb               | 2 +-
 spec/models/journaled/delivery_spec.rb | 6 +++---
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 6f286c1..7fcc710 100644
--- a/README.md
+++ b/README.md
@@ -92,7 +92,7 @@ Journaling provides a number of different configuation options that can be set i
 
   The number of seconds a persistent connection is allowed to sit idle before it should no longer be used.
 
-#### `Journaled.http_open_timeout` (default: 15 seconds)
+#### `Journaled.http_open_timeout` (default: 2 seconds)
 
   The number of seconds before the :http_handler should timeout while trying to open a new HTTP session.
 
diff --git a/lib/journaled.rb b/lib/journaled.rb
index e6036c7..0310178 100644
--- a/lib/journaled.rb
+++ b/lib/journaled.rb
@@ -10,7 +10,7 @@ module Journaled
   mattr_accessor :default_app_name
   mattr_accessor(:job_priority) { 20 }
   mattr_accessor(:http_idle_timeout) { 5 }
-  mattr_accessor(:http_open_timeout) { 15 }
+  mattr_accessor(:http_open_timeout) { 2 }
   mattr_accessor(:http_read_timeout) { 60 }
 
   def development_or_test?
diff --git a/lib/journaled/version.rb b/lib/journaled/version.rb
index 77935f5..4c4ba1c 100644
--- a/lib/journaled/version.rb
+++ b/lib/journaled/version.rb
@@ -1,3 +1,3 @@
 module Journaled
-  VERSION = "2.4.0".freeze
+  VERSION = "2.5.0".freeze
 end
diff --git a/spec/models/journaled/delivery_spec.rb b/spec/models/journaled/delivery_spec.rb
index e6019f8..83a5f4e 100644
--- a/spec/models/journaled/delivery_spec.rb
+++ b/spec/models/journaled/delivery_spec.rb
@@ -191,7 +191,7 @@
     end
 
     it "will set http_open_timeout by default" do
-      expect(subject.kinesis_client_config).to include(http_open_timeout: 15)
+      expect(subject.kinesis_client_config).to include(http_open_timeout: 2)
     end
 
     it "will set http_read_timeout by default" do
@@ -207,8 +207,8 @@
 
     context "when Journaled.http_open_timeout is specified" do
       it "will set http_open_timeout by specified value" do
-        allow(Journaled).to receive(:http_open_timeout).and_return(2)
-        expect(subject.kinesis_client_config).to include(http_open_timeout: 2)
+        allow(Journaled).to receive(:http_open_timeout).and_return(1)
+        expect(subject.kinesis_client_config).to include(http_open_timeout: 1)
       end
     end