Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit usage of rescue *SERVER_ERRORS #143

Open
rzane opened this issue Jan 23, 2025 · 0 comments
Open

Audit usage of rescue *SERVER_ERRORS #143

rzane opened this issue Jan 23, 2025 · 0 comments

Comments

@rzane
Copy link
Contributor

rzane commented Jan 23, 2025

There are several examples like this:

begin
  # do something
rescue *SERVER_ERRORS
  # handle error
end

Since #63, the ServerErrorMiddleware will also rescue these exceptions and reraise as UnrecoverableConnectivityError. That means those rescues will never actually be executed at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant