Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacing PublicSuffix with Rails' builtin TLD handling #68

Open
aburgel opened this issue Nov 9, 2018 · 1 comment
Open

Comments

@aburgel
Copy link
Collaborator

aburgel commented Nov 9, 2018

We use PublicSuffix to extract the domain of the host so we can pull out the correct wildcard domain.

An alternative may be to use config.action_dispatch.tld_length to do the same thing, since we should be able to rely on the app to have this configured if it is running on a domain with a 2+ level TLD.

@jmileham
Copy link
Member

jmileham commented Nov 9, 2018

One advantage of the dynamic approach we have is that if you're, e.g. operating a multi-tenant app with multiple host names, some of which have multi-level public suffixes, and you have TT wildcard cookies enabled, this would Just Work for you. It may be that with the PR you just merged the existing pain points of PublicSuffix domain validation have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants