From c68e472e02cf08f9ea73dbaade9aae8c576e3c0f Mon Sep 17 00:00:00 2001
From: Sam Moore <sam@betterment.com>
Date: Fri, 29 Jan 2021 10:02:59 -0500
Subject: [PATCH] updates for v4 TT compatability (#59)

* updates for v4 TT compatability

* add v4 post app identifier endpoint
* remove v4 app identifier visitor configs endpoint

* remove unused api v1 endpoint from fake server

* bump version
---
 Makefile                  |  2 +-
 fakeserver/routes.go      | 16 ++++++++--------
 fakeserver/server_test.go |  8 ++++++--
 3 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/Makefile b/Makefile
index 991e735..dd8bd9d 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,6 @@
 SHELL = /bin/sh
 
-VERSION=1.2.0
+VERSION=1.3.0
 BUILD=`git rev-parse HEAD`
 
 LDFLAGS=-ldflags "-w -s \
diff --git a/fakeserver/routes.go b/fakeserver/routes.go
index d268785..77f83ba 100644
--- a/fakeserver/routes.go
+++ b/fakeserver/routes.go
@@ -139,6 +139,10 @@ func (s *server) routes() {
 		"/api/v1/identifier",
 		postV1Identifier,
 	)
+	s.handlePost(
+		"/api/v4/apps/{a}/versions/{v}/builds/{b}/identifier",
+		postV4AppIdentifier,
+	)
 	s.handleGet(
 		"/api/v1/visitors/{id}",
 		getV1Visitor,
@@ -167,14 +171,6 @@ func (s *server) routes() {
 		"/api/v4/apps/{a}/versions/{v}/builds/{b}/visitors/{id}/config",
 		getV4AppVisitorConfig,
 	)
-	s.handleGet(
-		"/api/v1/apps/{a}/versions/{v}/builds/{b}/identifier_types/{t}/identifiers/{i}/visitor_config",
-		getV1AppVisitorConfig,
-	)
-	s.handleGet(
-		"/api/v4/apps/{a}/versions/{v}/builds/{b}/identifier_types/{t}/identifiers/{i}/visitor_config",
-		getV4AppVisitorConfig,
-	)
 	s.handleGet(
 		"/api/v1/split_details/{id}",
 		getV1SplitDetail,
@@ -271,6 +267,10 @@ func postV1Identifier(*http.Request) (interface{}, error) {
 	return map[string]v1Visitor{"visitor": visitor}, nil
 }
 
+func postV4AppIdentifier(*http.Request) (interface{}, error) {
+	return getV4AppVisitorConfig()
+}
+
 func getV1Visitor() (interface{}, error) {
 	assignments, err := fakeassignments.Read()
 	if err != nil {
diff --git a/fakeserver/server_test.go b/fakeserver/server_test.go
index 6a22233..4365900 100644
--- a/fakeserver/server_test.go
+++ b/fakeserver/server_test.go
@@ -151,12 +151,16 @@ func TestVisitorConfig(t *testing.T) {
 	})
 }
 
-func TestIdentifierVisitorConfig(t *testing.T) {
+func TestAppIdentifier(t *testing.T) {
 	t.Run("it loads visitor config v4", func(t *testing.T) {
 		w := httptest.NewRecorder()
 		h := createHandler()
 
-		h.ServeHTTP(w, httptest.NewRequest("GET", "/api/v4/apps/foo/versions/1/builds/2020-01-02T03:04:05/identifier_types/user_id/identifiers/123/visitor_config", nil))
+		request := httptest.NewRequest("POST", "/api/v4/apps/foo/versions/1/builds/2020-01-02T03:04:05/identifier", nil)
+		request.Header.Add("Content-Type", "application/json")
+		request.Header.Add("Content-Length", "0")
+
+		h.ServeHTTP(w, request)
 
 		require.Equal(t, http.StatusOK, w.Code)