Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions after 1.5.0 can't be edited. #242

Open
mkultra333 opened this issue Mar 30, 2023 · 1 comment
Open

Versions after 1.5.0 can't be edited. #242

mkultra333 opened this issue Mar 30, 2023 · 1 comment

Comments

@mkultra333
Copy link

mkultra333 commented Mar 30, 2023

I've been using this bot for years as the base for my own bots. In versions 1.5.0 or less I can modify the files like market_maker.py, ws_thread.py etc to debug the bot and change it to suit my purposes. This is what you'd expect for a demonstration bot.

However from 1.6.0 onward some change has been made so that when I run marketmaker.exe it ignores any changes made to all the py files apart from the settings files.

This is not ideal for two reasons. It means users can't change the bot to do what they want it to do (no one really wants to just use it as a market maker putting out spreads of trades) and users can't debug it when api/maintenance changes cause the bot to malfunction (as happened after the March 23rd 2023 site maintenance.)

I think it would be better to go back to the previous setup where changes to market_maker.py, ws_thread.py etc would be reflected when you run marketmaker.exe, instead of ignored.

For people who want to use this bot as the basis for their own trading bot, you might want to use pip to install version 1.5.0 and avoid 1.6.0, although you'll also have to fix other issues, such as any new API changes, the problem in ws.funds() (see my other issue added here) and that, in ws_thread.py, ws.connect connects to testnet by default instead of mainnet.

@mkultra333
Copy link
Author

mkultra333 commented Mar 30, 2023

(The instructions say you can "subclass market_maker.OrderManager and override OrderManager.place_orders():" but this isn't any help if you want to make a change in ws_thread.py to get more information or fix an api change. There's not really any reason to restrict how users modify a demonstration bot that's meant as a foundation for custom bots.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant