Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Corepack and specify package manager version #2138

Closed
1 task done
minht11 opened this issue Jul 10, 2024 · 5 comments · Fixed by #2051
Closed
1 task done

Enable Corepack and specify package manager version #2138

minht11 opened this issue Jul 10, 2024 · 5 comments · Fixed by #2051
Labels
DevOps Changes related to DevOps, Continuous Integration, unit tests

Comments

@minht11
Copy link

minht11 commented Jul 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Feature description

This is not a public exposed feature request just an internal one.
I cloned the repo and installed yarn (because this repo uses it), but the issue was that my installed yarn was 4.3.1 and here it is probably ^1 something. I am not sure which one to use and don't really have a way to know besides guessing.

To allow easier suggest contributors enable corepack and specify which package manager version should be used inside package.json. This will not affect consumers of the library just the contributors.


My other suggestion would be to also switch to pnpm because in my opinion it seems bit better and more stable, but I digress.

@Borewit Borewit added DevOps Changes related to DevOps, Continuous Integration, unit tests and removed enhancement labels Jul 11, 2024
@Borewit
Copy link
Owner

Borewit commented Jul 11, 2024

Hi @minht11 , thanks for pointing this out. Looks like I am a bit behind, I did an attempt to upgrade the yarn (#2051), and was not directly successful. Are you interested created a PR?

@minht11
Copy link
Author

minht11 commented Jul 11, 2024

Sure. I am not that familiar with Yarn or Github Actions but I would be willing to try.
I saw in CI logs that the error is because of missing chai package.

Would you be interested in me migrating this repo from chai/mocha to native node test runner? Node 18/20 support it and API is almost identical so it should make yarn version migration easier (if you still want to use yarn wink pnpm).

@Borewit
Copy link
Owner

Borewit commented Jul 11, 2024

Would you be interested in me migrating this repo from chai/mocha to native node test runner? Node 18/20 support it and API is almost identical so it should make yarn version migration easier (if you still want to use yarn wink pnpm).

It weird if the such a dependency no longer works.

I have experience with node test runner. What I find very important is that my IntelliJ IDEA understand the unit test, and I can easily execute or debug a single test. We can try, do you mind to try the testrunner here: https://github.com/Borewit/peek-readable/blob/master/test/test.ts, as that is much less work to migrate. Or pick one of my other projects, if you prefer. They all have a very similar setup.

@minht11
Copy link
Author

minht11 commented Jul 11, 2024

Sure will open PR there, to test things out there.

@Borewit
Copy link
Owner

Borewit commented Jul 16, 2024

Updated to Yarn Berry, using Corepack in #2051

@Borewit Borewit closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Changes related to DevOps, Continuous Integration, unit tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants