Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

music-metadata 9.0.0 has still Buffer dependencies #2141

Closed
Borewit opened this issue Jul 12, 2024 · 1 comment · Fixed by #2142
Closed

music-metadata 9.0.0 has still Buffer dependencies #2141

Borewit opened this issue Jul 12, 2024 · 1 comment · Fixed by #2142
Assignees
Labels
bug Bug, will addressed with high priority

Comments

@Borewit
Copy link
Owner

Borewit commented Jul 12, 2024

          I'm not sure yet, music-metadata 9.0.0 gives me this error when trying to parse **mkv** and **webm** files:

image

Also, do I still need a buffer polyfill for the browser? If I remove it, I can only retrieve metadata from flac files, everything else gives me the error below:

image

I'm testing with the following code:

// for web files (URLs)
const response = await fetch( uri );
const metadata = await parseWebStream( response.body, response.headers.get('content-type'), { skipPostHeaders: true } );

// for FileSystem API files
const file = await handle.getFile();
const metadata = await parseBlob( file );

Thanks.

Originally posted by @hvianna in #2135 (comment)

@Borewit Borewit self-assigned this Jul 12, 2024
@Borewit Borewit added the bug Bug, will addressed with high priority label Jul 12, 2024
@Borewit
Copy link
Owner Author

Borewit commented Jul 12, 2024

Fixed in v9.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, will addressed with high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant