-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce code formatting #2191
Comments
I am interested, the eslint with all it's sub dependencies is very distracting, way to complex to configure to my liking. Can we postpone the space to tabs, to avoid each and every line will changed with this PR? Like the test runner changes, are you willing to do the change for the dependencies (those I own) as well? Preferably starting with the dependencies, and then the dependent packages. Maybe good to start with peek-readable as well |
Yeah, spaces/tabs can wait. |
I am open to better alternatives. These are all things which had working perfectly at certain point, but then due to required updates / dependency deprecation, things just became in opinion just to complex and distracting. |
Resolved by #2204 |
Is there an existing issue for this?
Feature description
My proposal would be:
The first point is the main part, others are in decreasing importance. Would be willing to provide PR to 1 or all points.
Prettier is in project dependencies but does not seem to be used.
In vscode formatting does not even work even if forced, because prettier path does not exist:
music-metadata/.vscode/settings.json
Line 7 in 779b319
on my machine changing It to makes it work:
The text was updated successfully, but these errors were encountered: