Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id3v2.3 & id3v2.4 W-Frames are decoded incorrectly #2206

Closed
2 tasks done
Borewit opened this issue Aug 9, 2024 · 0 comments · Fixed by #2207
Closed
2 tasks done

id3v2.3 & id3v2.4 W-Frames are decoded incorrectly #2206

Borewit opened this issue Aug 9, 2024 · 0 comments · Fixed by #2207
Labels
bug Bug, will addressed with high priority

Comments

@Borewit
Copy link
Owner

Borewit commented Aug 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

music-metadata version

10.0.1

Current Behavior

Following id3v2.3 & id3v2.4 W-Frames are incorrectly decoded:

  1. WCOM
  2. WCOP
  3. WOAF
  4. WOAR
  5. WOAS
  6. WORS
  7. WPAY
  8. WPUB

May contain the NULL character end the end of decoded value

Expected Behavior

To have no NULL character end the end of decoded value

Attached audio sample?

  • I have provided sufficient information to reproduce the issue
@Borewit Borewit added the bug Bug, will addressed with high priority label Aug 9, 2024
@Borewit Borewit changed the title id3v2.3 & id3v2.4 W-Frames are incorrectly decoded id3v2.3 & id3v2.4 W-Frames are decoded incorrectly Aug 9, 2024
Borewit added a commit that referenced this issue Aug 9, 2024
@Borewit
Fix id3v2.3 & id3v2.4 W-Frames
e30ed13 
Resolves #2206
Borewit added a commit that referenced this issue Aug 9, 2024
@Borewit
Fix id3v2.3 & id3v2.4 W-Frames
85e55df 
Resolves #2206
@Borewit Borewit mentioned this issue Aug 9, 2024
Merged
Borewit added a commit that referenced this issue Aug 9, 2024
@Borewit
Fix id3v2.3 & id3v2.4 W-Frames
551ccaf 
Resolves #2206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug, will addressed with high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix id3v2.3 & id3v2.4 W-Frames Borewit/music-metadata
1 participant
@Borewit