Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari parseBlob failure #2221

Open
2 tasks done
bradleat opened this issue Aug 20, 2024 · 9 comments
Open
2 tasks done

Safari parseBlob failure #2221

bradleat opened this issue Aug 20, 2024 · 9 comments
Labels
bug Bug, will addressed with high priority

Comments

@bradleat
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

music-metadata version

10.2.0

Current Behavior

When parsing a blob with Safari, I get the following error:

TypeError: ReadableStreamBYOBReader needs a ReadableByteStreamController

Expected Behavior

No response

Attached audio sample?

  • I have provided sufficient information to reproduce the issue
@bradleat bradleat added the bug Bug, will addressed with high priority label Aug 20, 2024
@bradleat
Copy link
Author

I've tried using:

https://github.com/MattiasBuelens/web-streams-polyfill

It doesn't work.

@Borewit
Copy link
Owner

Borewit commented Aug 20, 2024

Do you have the same issue here using Safari?

A workaround is:

import {parseBuffer} from 'music-metadata';

let blob; // Assume this Blob is assigned

const metadata = await parseBuffer(await blob.bytes()), {mimeType: blob.type});

(I have not tested it)

Ref:

@Borewit
Copy link
Owner

Borewit commented Sep 3, 2024

Is there is any news, feel free to re-open

@Borewit Borewit closed this as completed Sep 3, 2024
@jonluca
Copy link

jonluca commented Jan 18, 2025

Image

Yes, the issue occurs there as well. The proposed workaround works though, for what its worth.

@Borewit
Copy link
Owner

Borewit commented Jan 18, 2025

I will try to switch from BYOB (bring your own buffer)/byte stream to the default stream.

Ref: https://developer.mozilla.org/docs/Web/API/ReadableStream/ReadableStream

@Borewit
Copy link
Owner

Borewit commented Jan 18, 2025

@jonluca
Copy link

jonluca commented Jan 19, 2025

Image

Same issue

@Borewit
Copy link
Owner

Borewit commented Jan 19, 2025

Do you mind to try one more time @jonluca ? GUI should show v10.8.0-beta.3", otherwise please reload your browser.

@jonluca
Copy link

jonluca commented Jan 19, 2025

Image

New error this time haha

Im-Beast added a commit to Im-Beast/music-player that referenced this issue Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, will addressed with high priority
Projects
None yet
Development

No branches or pull requests

3 participants