Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The structure returned by the lyrics analysis is incorrect. #2277

Closed
2 tasks done
xushengfeng opened this issue Nov 3, 2024 · 1 comment · Fixed by #2285
Closed
2 tasks done

The structure returned by the lyrics analysis is incorrect. #2277

xushengfeng opened this issue Nov 3, 2024 · 1 comment · Fixed by #2285
Assignees
@Borewit
Labels
bug Bug, will addressed with high priority

Comments

@xushengfeng
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

music-metadata version

10.5.1

Current Behavior

common.lyrics[0] is string

I don't know if the lyrics format I'm using is correct :(

image

image

Expected Behavior

Return the correct lyric format

Attached audio sample?

  • I have provided sufficient information to reproduce the issue
@xushengfeng xushengfeng added the bug Bug, will addressed with high priority label Nov 3, 2024
@Borewit Borewit self-assigned this Nov 10, 2024
@Borewit
Copy link
Owner

Borewit commented Nov 10, 2024 •
edited
Loading

Seems that the lyrics mapping is, depending on the format type, not inconsistent with the type.
Update: Found the audio sample, thanks! ✅

@Borewit Borewit mentioned this issue Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Borewit Borewit

Labels
bug Bug, will addressed with high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for LRC Lyrics Borewit/music-metadata
2 participants
@Borewit @xushengfeng