Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close web-stream-tokenizer #2316

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Jan 4, 2025

Properly close web-stream-tokenizer.
Add unit tests to cover web-stream.

Resolves #2314

@Borewit Borewit added the bug Bug, will addressed with high priority label Jan 4, 2025
@Borewit Borewit self-assigned this Jan 4, 2025
@coveralls
Copy link

coveralls commented Jan 4, 2025

Coverage Status

coverage: 96.967% (-0.006%) from 96.973%
when pulling b461fb5 on properly-close-web-stream-tokenizer
into 4c588a1 on master.

Add unit tests for web-stream
@Borewit Borewit force-pushed the properly-close-web-stream-tokenizer branch from 409e9dd to b461fb5 Compare January 4, 2025 19:50
@Borewit Borewit changed the title Fix handling reading AMR audio file from stream Properly handle EndOfStreamError, in case the length of the stream is unknown Jan 4, 2025
@Borewit Borewit changed the title Properly handle EndOfStreamError, in case the length of the stream is unknown Properly close web-stream-tokenize Jan 4, 2025
@Borewit Borewit changed the title Properly close web-stream-tokenize Properly close web-stream-tokenizer Jan 4, 2025
@Borewit Borewit merged commit 4f87d8f into master Jan 4, 2025
20 of 22 checks passed
@Borewit Borewit deleted the properly-close-web-stream-tokenizer branch January 4, 2025 19:53
@Borewit
Copy link
Owner Author

Borewit commented Jan 4, 2025

Fixed in v10.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, will addressed with high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release lock on Web Stream Reader after done parsing
2 participants