value.trim() is not a function

[r-flash]

Is there an existing issue for this?

• I have searched the existing issues

music-metadata version

10.9.0

Current Behavior

I'm getting the following error for any MP3 file I try to run parseFile on. I have added some logs before the problematic line and turns out the type of value is actually Uint8Array, not string.

Sample MP3 file

file:///mnt/hdd/Projects/music-browser/dist/main.js:7230
        value = value.trim();
                      ^

TypeError: value.trim is not a function
    at Id3v1StringType.get (file:///mnt/hdd/Projects/music-browser/dist/main.js:7230:23)
    at Object.get (file:///mnt/hdd/Projects/music-browser/dist/main.js:7206:47)
    at FileTokenizer.readToken (file:///mnt/hdd/Projects/music-browser/dist/main.js:49:22)
    at async ID3v1Parser.parse (file:///mnt/hdd/Projects/music-browser/dist/main.js:7260:24)
    at async MpegParser.parseID3v2 (file:///mnt/hdd/Projects/music-browser/dist/AbstractID3Parser-Ce8k_va_.js:42:13)
    at async MpegParser.parse (file:///mnt/hdd/Projects/music-browser/dist/AbstractID3Parser-Ce8k_va_.js:19:13)
    at async ParserFactory.parse (file:///mnt/hdd/Projects/music-browser/dist/main.js:6729:9)
    at async parseFile (file:///mnt/hdd/Projects/music-browser/dist/main.js:7339:16)
    at async file:///mnt/hdd/Projects/music-browser/dist/main.js:7453:17

Expected Behavior

No error is thrown.

Attached audio sample?

• I have provided sufficient information to reproduce the issue

[Borewit]

Hi @r-flash, that does not happen when I parse that file with [email protected].

Looking at your stack trace, you are using some post-processing of the code, maybe something odd is happening there.

Neither I can explain why you ending up value being an Uint8Array, and not a string:

music-metadata/lib/id3v1/ID3v1Parser.ts

Line 105 in 0b1a9b7

value = value.trim();

[Borewit]

Seems to work fine in the browser as well: https://audio-tag-analyzer.netlify.app/

Which JavaScript engine are you using?

[r-flash]

Thanks for the quick response! I'm using Node v23.4.0. I'll try to investigate whether it has something to do with the usage of Rollup.

[Borewit]

It is related to Node v23.4.0, same issue on my end.

[Borewit]

Caused by issue: nodejs/node#56219

Related to sindresorhus/file-type#703

You can reproduce the issue like this:

it('Node Windows-1252 decode bug', () => {
  const textDecoder = new TextDecoder('Windows-1252');
  const binary = new Uint8Array([72, 101, 108, 108, 111]);
  const text = textDecoder.decode(binary);
  assert.strictEqual(typeof(text), 'string', 'expect a string');
});

Just update to a newer Node.js version, at least in v23.7.0 it seems resolved.

[r-flash]

I see, thanks a lot!