Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations not work on the latest version of VSCode. #78

Open
Torther opened this issue Oct 11, 2024 · 16 comments
Open

Animations not work on the latest version of VSCode. #78

Torther opened this issue Oct 11, 2024 · 16 comments

Comments

@Torther
Copy link

Torther commented Oct 11, 2024

It seems that Animations cannot run on the latest version of VSCode. Here is the version information of the VSCode being used.

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0

I tried two different installation methods, but neither of them achieved the expected result when the animation was enabled.

When I tried using a lower version of VSCode, it worked properly.

Below is the version information that I am using which is working properly.

Version: 1.90.0
Commit: 89de5a8d4d6205e5b11647eb6a74844ca23d2573
Date: 2024-06-04T19:34:48.028Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 24.0.0
@Torther
Copy link
Author

Torther commented Oct 11, 2024

I also tested the latest several versions and found that the August update v1.93 of VSCode works fine. The issue started occurring after the September update v1.94, and the last available version that works is 1.93.1.

Version: 1.93.1
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0

@00gle
Copy link

00gle commented Oct 11, 2024

Me too!

@BrandonKirbyson
Copy link
Owner

Ok thank you for providing all that info. Oddly, it works for me on the exact same vscode v1.94.2 build as you gave.

Although, unfortunately it seems the Apc extension may not be working for a bit given a recent issue.

Given that Custom CSS and JS seems to be working, could you try that option again but disable and re-enable it using Disable Custom CSS and JS and Enable Custom CSS and JS and then try running Animations: Install Animations twice if that doesn't fix it. Also please make sure to restart vscode when prompted to on any of these steps.

Thank you so much for your help, let me know if anything fixes it but otherwise I can look more into it tomorrow.

@Torther
Copy link
Author

Torther commented Oct 11, 2024

image

According to the method you provided, it is now working successfully. Thank you for your help.

@krasnw
Copy link

krasnw commented Oct 11, 2024

I have the same problem. Reinstallation makes no effect.

@BrandonKirbyson
Copy link
Owner

Note to everyone: Apc Customize UI++ is currently not working, use Custom CSS and JS for now.

@Torther Ok great! Can I ask at what point did it work, did you have to run Animations: Install Animations after disabling and re-enabling Custom CSS and JS?

@krasnw did you try the steps with Custom CSS and JS above?

@XiaMi-Long
Copy link

This is because version 1.94 of VSCode changed the location of many resource files and removed some information, causing many similar plugins to stop working. I released a plugin that adds animations to VSCode, you can check it out: https://marketplace.visualstudio.com/items?itemName=wwy.easy-anim-code

@XiaMi-Long
Copy link

In the past, plugins like ours that modified the UI would add CSS and JS to a specific file in the VSCode installation path. However, now that file may have been removed or renamed, causing these plugins to no longer function properly.

@XiaMi-Long
Copy link

This file modification might be related to the overall ESM migration in VSCode version 1.94, as mentioned on their official website.

@Torther
Copy link
Author

Torther commented Oct 12, 2024

@Torther Ok great! Can I ask at what point did it work, did you have to run Animations: Install Animations after disabling and re-enabling Custom CSS and JS?

I switched the installation method to Custom CSS and JS through Animations: Change Install Method and reinstalled the Custom CSS and JS plugin. Then I ran the Animations: Install Animations and finally ran Animations: Enable Animations. It is now working well.

@fadihanna123
Copy link

fadihanna123 commented Oct 13, 2024

Me too!
After latest update and after trying all steps above nothing works. I hope new solution come in future.

@BrandonKirbyson
Copy link
Owner

For everyone it is still not working could you verify you are running vscode with admin privileges and then run Animations: Install Animations and Enable Custom CSS and JS in that order.

If that works for anyone, please let me know. Otherwise could you provide your vscode info like this, thanks.

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z (3 days ago)
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0

@fadihanna123
Copy link

That helped me

For everyone it is still not working could you verify you are running vscode with admin privileges and then run Animations: Install Animations and Enable Custom CSS and JS in that order.

If that works for anyone, please let me know. Otherwise could you provide your vscode info like this, thanks.

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z (3 days ago)
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0

Thanks!
That worked for me.

@rafael-tonello
Copy link

rafael-tonello commented Oct 17, 2024

For everyone it is still not working could you verify you are running vscode with admin privileges and then run Animations: Install Animations and Enable Custom CSS and JS in that order.

If that works for anyone, please let me know. Otherwise could you provide your vscode info like this, thanks.

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z (3 days ago)
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0

Hi!
Here, if I run VSCode as administrator, it will change the user and probably cause me other problems. I'm on Ubutnu 22.04. Below is my VSCode information:

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Linux x64 6.8.0-47-generic

Thansk for your attention!

@NeilPandya
Copy link

NeilPandya commented Oct 18, 2024

For everyone it is still not working could you verify you are running vscode with admin privileges and then run Animations: Install Animations and Enable Custom CSS and JS in that order.

If that works for anyone, please let me know. Otherwise could you provide your vscode info like this, thanks.

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z (3 days ago)
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0

Hi @BrandonKirbyson,

First off, please accept my grateful thanks for your work on this extension!

I'm still having some trouble switching to Custom CSS and JS from Apc Customize UI++ to get VSCode Animations back to working order after the latest round of updates to VSCode/VSCodium. Below are my build specs for VSCodium:

Version: 1.94.2
Release: 24286
Commit: 62f778783c52510c94e687de293bc2ad230f9a67
Date: 2024-10-12T20:14:54.465Z
Electron: 30.5.1
ElectronBuildId: undefined
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Linux x64 6.8.0-47-generic

First, I searched for Custom CSS and JS in the Open VSX Registry, and couldn't find it. Therefore, I decided to clone the repo, and build it myself. I've included the Dockerfile code and helper scripts to build the image and run a container to export a .vsix file.

FROM node:slim

LABEL maintainer="[email protected]"

RUN apt-get update && \ 
    apt-get upgrade -y && \
    apt-get autoremove && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/*

RUN npm install -g yo@latest generator-code@latest vsce@latest

WORKDIR /mnt/
#!/bin/bash
# build-image.sh

# Function to check if Docker is installed
check_docker() {
    if ! command -v docker &> /dev/null; then
        echo "Docker is not installed. Please install Docker and try again."
        exit 1
    fi
}

# Check for Docker installation
check_docker

# Build the Docker image
docker build \
    -t neilpandya/node:vsix-generator .
#!/bin/bash
# run-container.sh

# Run the container
docker run \
    --name vsix-generator \
    --hostname vsix-generator \
    --rm \
    -it \
    --user $(id -u):$(id -g) \
    -v "$PWD"/:/mnt/"$PWD" \
    -w /mnt/"$PWD" \
    neilpandya/node:vsix-generator \
    bash
git clone https://github.com/be5invis/vscode-custom-css.git

cd vscode-custom-css

./build-image.sh && ./run-container.sh

# From within the container...
vsce package

If all goes well, it should output vscode-custom-css-7.4.0.vsix. Next, after launching VSCodium:

  1. I installed the output .vsix via Extensions: Install from VSIX and restarted.
  2. Then, in Animations: Install-Method settings for VSCode Animations, I switched from APC Customize UI++ to Custom CSS and JS and restarted VSCodium.
  3. Ran Animations: Install Animations; restarted.
  4. Ran Enable Custom CSS and JS; restarted.

Unfortunately, still no luck. Perhaps, building the .vsix myself for Custom CSS and JS wasn't a good approach?

Thanks again for your work and in advance for any advice or insight you can give!

@BrandonKirbyson
Copy link
Owner

@rafael-tonello Was it working before, when you were running vscode without admin privileges? Custom CSS and JS doesn't work without proper admin privileges.

Custom CSS and JS - Mac and Linux Users

@NeilPandya Thanks for providing so much info, the VSCodium build of this extension is probably slightly outdated, I can publish the newest version later today although I don't think anything was added that should fix it.
The only step you didn't seem to do is making sure you launched vscode with proper permissions, refer to the link above if you didn't do that. Otherwise, I'll publish the newest version and look into it on VSCodium later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants