Add builder ENS name when adding new builder #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carletex
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Thanks @damianmarti, this works great! And thanks for asking on the Ponder repo :)
Left a tiny comment
carletex
approved these changes
Jan 20, 2025
|
Thanks! Merging this 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the ENS name using another viem client always connected to mainnet.
It seems to be working fine.
Opened an issue on Ponder github because not using the client from the context is not recommended by Ponder, but I didn't find another way to do it ponder-sh/ponder#1446
After changing the indexed code, Ponder flushes all the data and reindexs all again, so no migration is needed and the ens field will be populated to all the builders.
Closes #5