Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possibility of None for date related variables #119

Open
leclairm opened this issue Feb 3, 2025 · 0 comments · May be fixed by #121
Open

possibility of None for date related variables #119

leclairm opened this issue Feb 3, 2025 · 0 comments · May be fixed by #121
Assignees
@leclairm
Labels
enhancement New feature or request refactor
Milestone
v0.1.0

Comments

@leclairm
Copy link
Contributor

leclairm commented Feb 3, 2025 •
edited
Loading

A few date related variables are allowed to be None making the code sometimes not very readable.

So far I've isolated 2 sets of variables that can be treated in 2 different refactoring efforts

ConfigCycle.start_date, ConfigCycle.end_date, ConfigCycle.period

_WhenBaseModel.at, _WhenBaseModel.before, _WhenBaseModel.after
@leclairm leclairm added this to the v0.1.0 milestone Feb 3, 2025
@leclairm leclairm added enhancement New feature or request refactor labels Feb 3, 2025
@leclairm leclairm self-assigned this Feb 5, 2025
@leclairm leclairm linked a pull request Feb 6, 2025 that will close this issue
Refactor dates handling #121
Draft
2 tasks
@leclairm leclairm linked a pull request Feb 6, 2025 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leclairm leclairm

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Refactor dates handling C2SM/Sirocco
1 participant
@leclairm