-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Intel OpenCL CPU] Unit_deviceFunctions_CompileTest_j0f_float fails with global is external, but doesn't have external or weak linkage! #455
Comments
These are passing for me. Are you using 2023.1 oneapi? |
I'm using the latest drivers from the compute-runtime repo. |
Then I'm not sure. I remember bringing these issues to you and then 2023.1 + SPIR-V Patches seems to have resolved these issues |
Seems to be due to illegal debug info generated to SPIR-V:
That is, it presents the missing optional parameter with DebugInfoNone although it should be omitted completely (since it's an optional one) or perhaps described as OpString None or such. |
...or not. Seems valid usage:
https://registry.khronos.org/SPIR-V/specs/unified1/OpenCL.DebugInfo.100.html#DebugInfoNone |
Yep, that was OK. After fixing two cases of optional args marked with DebugInfoNone, spirv-val passes. Sent PR KhronosGroup/SPIRV-Tools#5245 to fix these. |
This is likely the fshl intrinsic issue that is fixed in our SPIRV-Translator patch and my Intel OpenCL just (of course) uses the unpatched SPIRV-Translator. I'll upstream and see if it gets propagated. |
Might need upstreaming fixes to SPIR-V translator so the Intel CPU driver receives them. To investigate. See CHIP-SPV#455
Unit_deviceFunctions_CompileTest_j0f_float fails with `Global is external, but doesn't have external or weak linkage!
This might be yet another SPIRV-Translator builtin that is generated wrongly without the external attribute.
Also these tests seem to fail similarly:
The text was updated successfully, but these errors were encountered: