-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instances in vehicle_signal_specification/spec/Vehicle/MotionManagement /Steering.vspec for Axle are probably wrong #804
Comments
When proposing the model we opted for having Do you have a need for four wheel steering in your VSS usage? |
No, I don't have a need for four wheel steering. I just thought it might be unconsciously and wanted to point it out if it's a typo or something. But since it's intended I can close |
But we should at least add a comment/rationale, I can create a PR for that and bring up the discussion |
Sounds good |
MoM:
|
Two parts - Explain why we currently have Row[1,1] for steerable axle - Add some general info on the design decisions that we (implicitly) have made over time for instances Fixes COVESA#804 Signed-off-by: Erik Jaegervall <[email protected]>
Two parts - Explain why we currently have Row[1,1] for steerable axle - Add some general info on the design decisions that we (implicitly) have made over time for instances Fixes COVESA#804 Signed-off-by: Erik Jaegervall <[email protected]>
Isn't it the same as: ...
instances: [Row1]
... I think the confusion is caused by the use of the notation |
Yes, but then we would use a different pattern compared to other For current usage it does not really matter. Would maybe matter more if we would have something like in #642 where instances are proposed to be defined with type. Would make absolutely no difference for key/value-pair solutions but could make difference if you have a model based implementation where you want to call things like
|
While looking trough the VSS signals I saw that the instances for Axle in vehicle_signal_specification/spec/Vehicle/MotionManagement /Steering.vspec were Row[1,1] while they should probably be Row[1,2]
The text was updated successfully, but these errors were encountered: