Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of sub/filtered catalogs should be improved #75

Closed
bryanrcarlson opened this issue Nov 2, 2021 · 0 comments · Fixed by #76
Closed

Handling of sub/filtered catalogs should be improved #75

bryanrcarlson opened this issue Nov 2, 2021 · 0 comments · Fixed by #76
Labels
catalog Relates to the metadata catalog enhancement New feature or request
Milestone

Comments

@bryanrcarlson
Copy link
Contributor

A lot of cleanup can be done with how sub-catalogs (aka filtered catalogs) are handled.

  • URL should be more like an rest api; /catalog/{zoneName} should be something like /catalog/zones/{zoneName}
  • Page header can be improved. "Work Zone Catalog" seems awkward. Maybe something like: "Catalog filtered by zone: Work". Probably better options than this.
  • There's a lot of code copy/pasted for these filtered catalogs; see ZoneCatalogMetadataViewer, ProjectCatalogMetadataViewer, CatalogMetadataViewer (and soon TagMetadataViewer). Figure out a way to unify this. Create single component with parameters for what's being filtered? Pass a linq function to component?
@bryanrcarlson bryanrcarlson added enhancement New feature or request catalog Relates to the metadata catalog labels Nov 2, 2021
@bryanrcarlson bryanrcarlson added this to the 0.2 milestone Nov 2, 2021
@bryanrcarlson bryanrcarlson changed the title Sub catalogs should be handled more consistently Sub catalogs handling should be improved Nov 2, 2021
@bryanrcarlson bryanrcarlson changed the title Sub catalogs handling should be improved Handling of sub/filtered catalogs should be improved Nov 2, 2021
@bryanrcarlson bryanrcarlson linked a pull request Nov 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
catalog Relates to the metadata catalog enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant