Move CantBlock Additional Text from getAbilityText to getNonAbilityText

[Hanmac]

Stuff that is added to a Card Description by outside effects should not use getAbilityText, but more like getNonAbilityText or something else

currently, it is added only in getAbilityText, which because it is so complex, isn't updated often

forge/forge-game/src/main/java/forge/game/card/Card.java

Lines 2989 to 3027 in 95e5b7a

	if (game != null && isCreature() && isInPlay()) {
	for (final Card ca : game.getCardsIn(ZoneType.STATIC_ABILITIES_SOURCE_ZONES)) {
	if (equals(ca)) {
	continue;
	}
	for (final StaticAbility stAb : ca.getStaticAbilities()) {
	if (!stAb.checkConditions()) {
	continue;
	}
	boolean found = false;
	if (stAb.checkMode("CantBlockBy")) {
	if (!stAb.hasParam("ValidAttacker") || (stAb.hasParam("ValidBlocker") && stAb.getParam("ValidBlocker").equals("Creature.Self"))) {
	continue;
	}
	if (stAb.matchesValidParam("ValidAttacker", this)) {
	found = true;
	}
	} else if (stAb.checkMode(StaticAbilityCantAttackBlock.MinMaxBlockerMode)) {
	if (stAb.matchesValidParam("ValidCard", this)) {
	found = true;
	}
	}
	if (found) {
	final Card host = stAb.getHostCard();
	String currentName = host.getName();
	String desc = TextUtil.fastReplace(stAb.toString(), "CARDNAME", currentName);
	desc = TextUtil.fastReplace(desc, "NICKNAME", Lang.getInstance().getNickName(currentName));
	if (host.getEffectSource() != null) {
	desc = TextUtil.fastReplace(desc, "EFFECTSOURCE", host.getEffectSource().getName());
	}
	sb.append(desc);
	sb.append(linebreak);
	}
	}
	}
	}

which then causes this ugly refresh:

forge/forge-game/src/main/java/forge/game/GameAction.java

Lines 793 to 815 in 95e5b7a

	for (final StaticAbility stAb : c.getStaticAbilities()) {
	if (!stAb.checkConditions()) {
	continue;
	}
	if (stAb.checkMode("CantBlockBy")) {
	if (!stAb.hasParam("ValidAttacker") || (stAb.hasParam("ValidBlocker") && stAb.getParam("ValidBlocker").equals("Creature.Self"))) {
	continue;
	}
	for (Card creature : Iterables.filter(game.getCardsIn(ZoneType.Battlefield), CardPredicates.Presets.CREATURES)) {
	if (stAb.matchesValidParam("ValidAttacker", creature)) {
	creature.updateAbilityTextForView();
	}
	}
	}
	if (stAb.checkMode(StaticAbilityCantAttackBlock.MinMaxBlockerMode)) {
	for (Card creature : Iterables.filter(game.getCardsIn(ZoneType.Battlefield), CardPredicates.Presets.CREATURES)) {
	if (stAb.matchesValidParam("ValidCard", creature)) {
	creature.updateAbilityTextForView();
	}
	}
	}
	}

it also would help to separate the features with "Non ability features"