Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ability to change the background card color without removing the thumbnail image #2250

Open
solokot opened this issue Dec 23, 2024 · 1 comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented

Comments

@solokot
Copy link
Contributor

solokot commented Dec 23, 2024

Subj. Reason: sometimes when adding a thumbnail image, Catima chooses a completely unrepresentative background color, which is then used when displaying the card. Currently this can only be fixed by directly editing catima.csv in the backup file.

The request is purely aesthetic and is low priority.

Example:
Screenshot_2024-12-19-17-49-58-167_me hackerchick catima
Галамарт2

@TheLastProject TheLastProject added the state: consensus-needed A consensus needs to be reached before this can be implemented label Dec 23, 2024
@TheLastProject
Copy link
Member

I'm quite confused why the getDominantColor function from Google's Palette class would pick green as dominant color there. Perhaps we should look at that instead, perhaps the default "swatch" is wrong.

I'm not quite sure what to do here. I'm a bit hesitant to add code to choose this manually as it increases code complexity. It definitely isn't easy right now because image color detection can override headercolor right now.

This is one to look at later perhaps, definitely have a lot of more important issues to deal with first yeah 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: consensus-needed A consensus needs to be reached before this can be implemented
Projects
None yet
Development

No branches or pull requests

2 participants