New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support K2 compatibility check #83

Open

Goooler opened this issue Aug 19, 2024 · 6 comments

Goooler commented Aug 19, 2024 •

edited

Loading

Is your feature request related to a problem? Please describe.

We use this action to check our plugin but seems it hasn't reported K2 compatibility issues. See https://github.com/ComposeGears/Valkyrie/blob/eede1d9e9f2744a8e88b72ea0bf341e954ab2d1e/.github/workflows/release.yml#L51-L69

Describe the solution you'd like

Check and fail.

Additional context

See ComposeGears/Valkyrie#134.

egorikftp commented Aug 20, 2024

Looks like not available yet.

Issue: https://youtrack.jetbrains.com/issue/MP-6825/Add-check-for-declared-compatibility-with-K2-mode

Author

Goooler commented Aug 20, 2024

Good to know!

egorikftp commented Sep 19, 2024

Implemented: https://github.com/JetBrains/intellij-plugin-verifier/releases/tag/1.378

egorikftp commented Sep 19, 2024

@ChrisCarini Could you please take a look?

Owner

ChrisCarini commented Sep 22, 2024

Hi @egorikftp - thanks for the update! Do you feel comfortable to work on the change and post an initial PR to support K2 check?

egorikftp commented Sep 24, 2024

Based on JetBrains/intellij-plugin-verifier#1150 description, verify plugin will report CompatibilityProblem related to k2 mode.

I checked on Valkyrie and it reports this error if I remove k2 info from plugin.xml

https://github.com/ComposeGears/Valkyrie/actions/runs/11009050955/job/30567880528

It looks like nothing additional needs to be integrated 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment