Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress debug message when dragging furniture off the ledge #78847

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

Night-Pryanik
Copy link
Contributor

Summary

None

Purpose of change

Describe the solution

Added a new parameter for furn_set function which allows suppressing showing of debug message, default to false. Applied this new parameter for cases of dragging furniture off the ledge and deploying furniture on open air. Removed now-unneeded ALLOW_ON_OPEN_AIR flag from stepladders (as furniture).

Describe alternatives you've considered

None.

Testing

  • Dragged chair off the ledge. No debug message.
  • Deployed stepladder on the open air. No debug message.

Additional context

None.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 30, 2024
@PatrikLundell
Copy link
Contributor

Do the tests really cover everything that should be covered? It seems the negative tests are missing.
What happens if you try to deploy something that should fall (i.e. non step ladder furniture)? Will it refuse to be deployed, and, if not, will it fall as it should?

Also, I assume the chair, which probably was pushed off the ledge (unless the PC was flying) was confirmed to fall as it should (no reason to assume it wouldn't still fall when a message is removed, but still).
Similarly, I assume the step ladder didn't fall.

@Night-Pryanik
Copy link
Contributor Author

I'm afraid you're misunderstanding the gist of this PR. This PR is NOT about furniture falling down or not. Non-deployable furniture not falling down was addressed years ago in #47751. Deployable furniture not falling down was addressed in #77083. So, in short, furniture is falling down as it should, both deployable and non-deployable.
This PR is trying to address an issue of debug message showing up when dragging furniture off the ledge.

@PatrikLundell
Copy link
Contributor

I did understand what the PR addresses, but I still think it's reasonable to test that there aren't any unexpected side effects, i.e. that the previous behavior remains unchanged.

@Night-Pryanik
Copy link
Contributor Author

My tests showed that furniture is falling as it was previously. I didn't notice any unexpected side effects or changes in furniture falling behavior. The only thing that changed is debug message no longer showing up when furniture is dragged off the ledge.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 30, 2024
@Maleclypse Maleclypse merged commit 2d8e07d into CleverRaven:master Dec 31, 2024
21 of 26 checks passed
@Night-Pryanik Night-Pryanik deleted the allow-on-open-air branch January 1, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushing furniture off the ledge results in a debugmsg error
3 participants