Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor callbacks to use the callbacks in ClimaTimeSteppers #3504

Open
ph-kev opened this issue Jan 2, 2025 · 0 comments · May be fixed by #3514
Open

Refactor callbacks to use the callbacks in ClimaTimeSteppers #3504

ph-kev opened this issue Jan 2, 2025 · 0 comments · May be fixed by #3514
Assignees
@ph-kev

Comments

@ph-kev
Copy link
Member

ph-kev commented Jan 2, 2025 •
edited
Loading

In callback_helpers.jl, we use call_every_n_steps and call_every_dt. Both of these can be replaced by the equivalent callbacks in ClimaTimeSteppers.

The only functionality that need to be implemented for callbacks in ClimaTimeSteppers is call_at_end and save_positions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ph-kev ph-kev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace ClimaAtmos callbacks with CTS callbacks CliMA/ClimaAtmos.jl
1 participant
@ph-kev