Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect style in HydrostaticFreeSurfaceModel constructor #3966

Open
glwagner opened this issue Dec 2, 2024 · 0 comments
Open

Incorrect style in HydrostaticFreeSurfaceModel constructor #3966

glwagner opened this issue Dec 2, 2024 · 0 comments
Labels
cleanup 🧹 Paying off technical debt

Comments

@glwagner
Copy link
Member

glwagner commented Dec 2, 2024

I think this changed recently so I wanted to bring up the fact that these constructors incorrectly use TitleCase when they should use camel_case (because they do not construct types):

Gⁿ = HydrostaticFreeSurfaceTendencyFields(velocities, free_surface, grid, tracernames(tracers)),
G⁻ = PreviousHydrostaticTendencyFields(Val(timestepper), velocities, free_surface, grid, tracernames(tracers)),

More specifically HydrostaticFreeSurfaceTendencyFields is a legacy constructor whose style should be changed. Unfortunately, for some reason PreviousHydrostaticTendencyFields got added recently with incorrect style so this will need to be changed as well.

@glwagner glwagner added the cleanup 🧹 Paying off technical debt label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

No branches or pull requests

1 participant