Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does SplitRungeKutta3 support checkpointing? #4004

Open
glwagner opened this issue Dec 17, 2024 · 3 comments
Open

Does SplitRungeKutta3 support checkpointing? #4004

glwagner opened this issue Dec 17, 2024 · 3 comments
Labels
bug 🐞 Even a perfect program still has bugs question 💭 No such thing as a stupid question

Comments

@glwagner
Copy link
Member

It would seem not since all we have is:

set_time_stepper!(timestepper::RungeKutta3TimeStepper, file, model_fields) =
set_time_stepper_tendencies!(timestepper, file, model_fields)
set_time_stepper!(timestepper::QuasiAdamsBashforth2TimeStepper, file, model_fields) =
set_time_stepper_tendencies!(timestepper, file, model_fields)

The mystery of how @simone-silvestri does checkpointing thus endures.

@glwagner glwagner added bug 🐞 Even a perfect program still has bugs question 💭 No such thing as a stupid question labels Dec 17, 2024
@glwagner
Copy link
Member Author

Hmm actually I take that back, I guess RK3 shouldn't require checkpointing. So the real issue is that we save the tendencies for RungeKutta3!

@ali-ramadhan
Copy link
Member

Ah so it seems that checkpointing does work for RK3 but it's just a bit inefficient as it saves tendencies to disk when it doesn't need to? Curious if this is also true for hydrostatic.

@glwagner
Copy link
Member Author

ummmmm well with hydrostatic RK3 its called SplitRungeKutta3TimeStepper which doesn't appear to have bespoke methods in checkpointer.jl so not sure what's happening there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Even a perfect program still has bugs question 💭 No such thing as a stupid question
Projects
None yet
Development

No branches or pull requests

2 participants