From d5f8ee93036734e26cfad5a796cd6519d49f6704 Mon Sep 17 00:00:00 2001 From: Clyde D'Souza Date: Wed, 23 Dec 2020 15:12:12 +1300 Subject: [PATCH 1/3] Make comments consistent --- Src/Horoscope/ChineseZodiac.cs | 2 +- Src/Horoscope/Model/BaseZodiacModel.cs | 2 +- Src/Horoscope/Model/ChineseZodiacModel.cs | 3 +++ Src/Horoscope/Model/ZodiacModel.cs | 4 ++-- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Src/Horoscope/ChineseZodiac.cs b/Src/Horoscope/ChineseZodiac.cs index e5600cf..f14d176 100644 --- a/Src/Horoscope/ChineseZodiac.cs +++ b/Src/Horoscope/ChineseZodiac.cs @@ -37,7 +37,7 @@ public static ChineseZodiacModel GetZodiacSign(ChineseZodiacSigns requestedZodia /// /// Gets all zodiac signs and details for each sign. /// - /// List of zodiac signs each as a Zodiac sign object. + /// List of zodiac signs each as a zodiac sign object. public static List GetAllZodiacSigns() { return ChineseZodiacHelper.InitializeAndGetAllZodiacSigns().Values.ToList(); diff --git a/Src/Horoscope/Model/BaseZodiacModel.cs b/Src/Horoscope/Model/BaseZodiacModel.cs index f3fe2c8..57365e6 100644 --- a/Src/Horoscope/Model/BaseZodiacModel.cs +++ b/Src/Horoscope/Model/BaseZodiacModel.cs @@ -1,7 +1,7 @@ namespace Horoscope.Model { /// - /// Base Zodiac sign object containing information common to all Zodiac signs. + /// Base zodiac sign object containing information common to all zodiac signs. /// public class BaseZodiacModel { diff --git a/Src/Horoscope/Model/ChineseZodiacModel.cs b/Src/Horoscope/Model/ChineseZodiacModel.cs index 2e98038..67eb8e6 100644 --- a/Src/Horoscope/Model/ChineseZodiacModel.cs +++ b/Src/Horoscope/Model/ChineseZodiacModel.cs @@ -1,5 +1,8 @@ namespace Horoscope.Model { + /// + /// The Chinese zodiac sign object containing information on each Chinese zodiac sign. + /// public class ChineseZodiacModel: BaseZodiacModel { internal ChineseZodiacModel(string name, string english, string zodiacPersonality, ChineseZodiacElements chineseZodiacFixedElement, YinYang yinYang) diff --git a/Src/Horoscope/Model/ZodiacModel.cs b/Src/Horoscope/Model/ZodiacModel.cs index ed28490..f650528 100644 --- a/Src/Horoscope/Model/ZodiacModel.cs +++ b/Src/Horoscope/Model/ZodiacModel.cs @@ -1,7 +1,7 @@ namespace Horoscope.Model { /// - /// The Zodiac sign object containing information on each Zodiac sign. + /// The zodiac sign object containing information on each zodiac sign. /// public class ZodiacModel: BaseZodiacModel { @@ -13,7 +13,7 @@ internal ZodiacModel(string name, string english, ZodiacDateModel start, ZodiacD } /// - /// The duration for this Zodiac sign. + /// The duration for this zodiac sign. /// Example: December 22 to January 19. /// public string ZodiacDuration { get { return $"{ToMonth(ZodiacStartDate.Month)} {ZodiacStartDate.Date} to {ToMonth(ZodiacEndDate.Month)} {ZodiacEndDate.Date}"; } } From 03fd78b23a294d36641b691b6d44a07136e2ffb9 Mon Sep 17 00:00:00 2001 From: Clyde D'Souza Date: Wed, 23 Dec 2020 15:14:29 +1300 Subject: [PATCH 2/3] Simplify interpolation --- Src/Horoscope.TestConsole/ChineseZodiacExamples.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Src/Horoscope.TestConsole/ChineseZodiacExamples.cs b/Src/Horoscope.TestConsole/ChineseZodiacExamples.cs index ed4d814..d3fa5fe 100644 --- a/Src/Horoscope.TestConsole/ChineseZodiacExamples.cs +++ b/Src/Horoscope.TestConsole/ChineseZodiacExamples.cs @@ -13,17 +13,17 @@ class ChineseZodiacExamples public static void ShowZodiacBasicExamples() { var allFireChineseSigns = ChineseZodiac.GetAllZodiacSignsForAnElement(ChineseZodiacElements.Fire); - Console.WriteLine($"\nGet a list of all Chinese zodiac signs that are associated with {ChineseZodiacElements.Fire.ToString()}"); + Console.WriteLine($"\nGet a list of all Chinese zodiac signs that are associated with {ChineseZodiacElements.Fire}"); foreach (var currentZodiacSign in allFireChineseSigns) { Console.WriteLine($"-\t{currentZodiacSign.ZodiacEnglishTranslation}"); } var dragonZodiacSign = ChineseZodiac.GetZodiacSign(ChineseZodiacSigns.Dragon); - Console.WriteLine($"\nPersonality trait for {ChineseZodiacSigns.Dragon.ToString()} people: {dragonZodiacSign.ZodiacPersonality}"); + Console.WriteLine($"\nPersonality trait for {ChineseZodiacSigns.Dragon} people: {dragonZodiacSign.ZodiacPersonality}"); var zodiacSignFor2018 = ChineseZodiac.GetChineseZodiacElementBasedOnYear(2018); - Console.WriteLine($"\nChinese zodiac element for 2018 is {zodiacSignFor2018.ToString()}"); + Console.WriteLine($"\nChinese zodiac element for 2018 is {zodiacSignFor2018}"); var zodiacSignForDate = ChineseZodiac.GetZodiacSignForDate(new DateTime(1966, 2, 12)); Console.WriteLine($"\nChinese zodiac sign for {new DateTime(1966, 2, 12).ToShortDateString()} is {zodiacSignForDate.ZodiacEnglishTranslation}"); From 2029f39b08aa2c82adf7b9d539f787eb370de6b2 Mon Sep 17 00:00:00 2001 From: Clyde D'Souza Date: Wed, 23 Dec 2020 15:15:23 +1300 Subject: [PATCH 3/3] Bump version --- Src/Horoscope.nuspec | 2 +- Src/Horoscope/Horoscope.csproj | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Src/Horoscope.nuspec b/Src/Horoscope.nuspec index 48f4c8b..b581009 100644 --- a/Src/Horoscope.nuspec +++ b/Src/Horoscope.nuspec @@ -2,7 +2,7 @@ Horoscope - 0.9.1 + 0.9.3 Horoscope Clyde D'Souza Clyde D'Souza diff --git a/Src/Horoscope/Horoscope.csproj b/Src/Horoscope/Horoscope.csproj index 02cddf2..d44159a 100644 --- a/Src/Horoscope/Horoscope.csproj +++ b/Src/Horoscope/Horoscope.csproj @@ -5,7 +5,7 @@ Clyde D'Souza false Horoscope - 0.9.2 + 0.9.3 https://github.com/ClydeDz/horoscope-nuget @@ -14,8 +14,8 @@ A .NET library for zodiac signs. Get details on each zodiac sign, pass a date and know which zodiac sign it falls in or get a list of all zodiac signs. Now includes Chinese zodiac signs and elements! Copyright (c) 2018 Clyde D'Souza Now includes Chinese zodiac signs, fixed elements (i.e., wood, fire, earth, metal, water) and yin yang associated with each Chinese zodiac sign. More release notes here: https://github.com/ClydeDz/horoscope-nuget/releases - 0.9.2.0 - 0.9.2.0 + 0.9.3.0 + 0.9.3.0 Horoscope true