Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Remove material design icons dependency #2526

Open
christian-byrne opened this issue Feb 12, 2025 · 5 comments
Open

[DevTask] Remove material design icons dependency #2526

christian-byrne opened this issue Feb 12, 2025 · 5 comments

Comments

@christian-byrne
Copy link
Collaborator

christian-byrne commented Feb 12, 2025

Vendored materialdesign.icons.min.css is 0.3 Mb showing 100% unutilized.

Image

Locations it is still used:

┆Issue is synchronized with this Notion page by Unito

@huchenlei
Copy link
Member

Unfortunately it is still widely used by custom nodes.

@christian-byrne
Copy link
Collaborator Author

It is? I must be interpreting the query results wrong. I only see references in Comfy-Org repos

@christian-byrne
Copy link
Collaborator Author

@christian-byrne
Copy link
Collaborator Author

christian-byrne commented Feb 12, 2025

I see, I need to expand the query to include JS and ComfyButton. I edited issue body with more refined query showing the 10 custom nodes using it.

@huchenlei
Copy link
Member

I see, I need to expand the query to include JS and ComfyButton. I edited issue body with more refined query showing the 10 custom nodes using it.

Let's find a way to offer them migration option to primevue icons to help them move away from material design icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants