Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTask] Structure selection data type #542

Open
christian-byrne opened this issue Feb 18, 2025 · 0 comments
Open

[DevTask] Structure selection data type #542

christian-byrne opened this issue Feb 18, 2025 · 0 comments
Assignees
@huchenlei
Labels
bug Something isn't working

Comments

@christian-byrne
Copy link
Contributor

The data type passed to onSelectionChange is too abstrast, requiring costly runtime type checks by subscribers like frontend selection toolbar. The data type can be made a struct that organizes into LGraphNode, LGraphGroup, RerouteNode, etc.
@christian-byrne christian-byrne changed the title [DevTask] Structure selection [DevTask] Structure selection data type Feb 18, 2025
@christian-byrne christian-byrne mentioned this issue Feb 18, 2025
Merged
@huchenlei huchenlei self-assigned this Feb 18, 2025
@huchenlei huchenlei added the bug Something isn't working label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huchenlei huchenlei

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huchenlei @christian-byrne