Responsive carousel component #1045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliansotuyo
force-pushed
the
responsive-carousel-component
branch
from
9c37327 to
bc03a14
Compare
alcferreira
suggested changes
Jun 2, 2021
There was a problem hiding this comment.
Cool! Here are some points that I found out while testing it... Worth mentioning that I haven't reviewed the code just yet
- we should add a default value for qtyOfSlidesPerSet so it won't break the app when it's undefined
qtyOfSlidesPerSetwon't work with a number, it only works with an array. When we pass a number, it always renders 2 slides per set
qtyOfSlidesPerSetdoesn't seem to be working with an array set as well.. It seems like it always get the second item from the array and use it disregarding the screen size- We should be able to customize some slide props like border-radius
- The arrow buttons should be
smallby default, right? - Should we be able pass along left/right button on our own? Say we would like to pass a different icon or different button, should we be able to?
- Something is off with the
infiniteLoop
alcferreira
reviewed
Jun 10, 2021
packages/carousel/src/Carousel.js
Outdated
Comment on lines
24
to
25
| leftButton, | ||
| rightButton, |
There was a problem hiding this comment.
Let's remove ambiguity with leftButtonProps and rightButtonProps
alcferreira
reviewed
Jun 10, 2021
packages/carousel/src/Carousel.js
Outdated
Comment on lines
150
to
151
| {...leftButton} | ||
| icon={leftButton?.icon || <SmChevronLeft size={24} />} |
There was a problem hiding this comment.
if we pass props after the default props, we don't have to to this condition icon={leftButton?.icon || <SmChevronLeft size={24} />}
alcferreira
reviewed
Jun 10, 2021
packages/carousel/src/Carousel.js
Outdated
| infiniteLoop: PropTypes.bool, | ||
| style: PropTypes.oneOfType([PropTypes.object, PropTypes.array]), |
There was a problem hiding this comment.
why do we need a prop called style? 🤔
affects: @crave/farmblocks-carousel BREAKING CHANGE: add infinite scroll option; add number of slides displayed; add number of slides displayed by breakpoints; remove imageSet prop; add slides prop that accepts an array of nodes; modify carousel layout; add dots to navigate through slides; add arrows to navigate through slides ISSUES CLOSED: #1043
… components affects: @crave/farmblocks-carousel
…eparate component affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
…window hook affects: @crave/farmblocks-carousel
…e ones affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
affects: @crave/farmblocks-carousel
juliansotuyo
force-pushed
the
responsive-carousel-component
branch
from
4da8eb4 to
39c49e4
Compare
|
We will work on another version of this component soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issues
Code review checklist
Reviewer 1
Reviewer 2