Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spigot is changing the Materials again #272

Closed
PeachesMLG opened this issue Jun 18, 2024 · 1 comment
Closed

Spigot is changing the Materials again #272

PeachesMLG opened this issue Jun 18, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@PeachesMLG
Copy link
Contributor

PeachesMLG commented Jun 18, 2024

Looks like spigot are changing a lot of stuff again
image

I wasnt able to get too much information, but it looks like all the Enums are going to be deprecated and we will have a new system based on Interfaces instead.

Do we have a plan on how to support these going forwards? Potentially also realted to #239

Discord Link:
https://discord.com/channels/690411863766466590/741875863271899136/1252586934791045160

(Appologies for the lack of information, im not 100% sure as to what the future plans are myself, but ill try update this when I get more info)

@PeachesMLG PeachesMLG added the enhancement New feature or request label Jun 18, 2024
@CryptoMorin
Copy link
Owner

I'm already aware of the registries, but I don't think they'll "deprecate" the entire Material class in a sense of @Deprecated annotation. Material class will mostly be used for compile-time uses but registries should be used for runtime (config-valued) uses. That's my guess. Whatever happens, XMaterial enum will remain, but like you mentioned, it is related to the other issue, I created this long ago as a prototype: https://github.com/CryptoMorin/XSeries/blob/master/src/main/java/com/cryptomorin/xseries/abstractions/Material.java

Also you shouldn't be opening issues for these things, this is more like a casual conversion that should be somewhere else like the main Spigot thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants