Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Devise Locale Config #1645

Open
lomky opened this issue Mar 5, 2019 · 4 comments
Open

Clean up Devise Locale Config #1645

lomky opened this issue Mar 5, 2019 · 4 comments
Labels
Milestone

Comments

@lomky
Copy link
Member

lomky commented Mar 5, 2019

We should standardize our Devise wording either into separate files, or included in the base locale file, but not both.

Originally posted by @lomky in #1633 (comment)

@lomky
Copy link
Member Author

lomky commented Mar 10, 2019

@colinxfleming
Copy link
Member

Let's please go with separate file if we can, and vendor as much as possible!

@rcackerman
Copy link

@colinxfleming I'd be down for working on this! Would using the devise-i18n gem be of interest, or are you trying to limit dependencies?

@colinxfleming colinxfleming added this to the Hacknights! milestone Feb 12, 2023
@colinxfleming
Copy link
Member

let's use the devise-i18n gem. So the steps here are:

  • install that dependency
  • remove the existing devise yml files
  • confirm things still work in spanish mode (appending ?locale=es to a url will kick things into spanish mode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants