Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node-network-devtools change to dependencies #18108 #18109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: node-network-devtools change to dependencies #18108 #18109

wants to merge 1 commit into from

Conversation

GrinZero
Copy link
Contributor

@GrinZero GrinZero commented Jan 13, 2025 •
edited
Loading

Involved Issue / 该 PR 相关 Issue

Close #18108 18108

Example for the Proposed Route(s) / 路由地址示例

NOROUTE

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

We need to install node-network-devtools as dependencies. Because the files in Dockerfile will use NODE_ENV=production as the environment variable, this can create an effect similar to pnpm install -- prod, which can indeed cause startup issues during production.

@github-actions github-actions bot added dependencies This PR involves changes to dependencies Auto: Route Test Skipped PR involves no routes labels Jan 13, 2025
@GrinZero GrinZero mentioned this pull request Jan 13, 2025
Open
1 task
TonyRL
TonyRL reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@TonyRL TonyRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSSHub uses a multi-stage builds Dockerfile. Things happened in later stages have no effects on previous stages.

RSSHub/Dockerfile

Line 118 in 9893318

ENV NODE_ENV=production

NODE_ENV is defined in line 118. However, node_module is downloaded in

RSSHub/Dockerfile

Line 27 in 9893318

pnpm install --frozen-lockfile && \
without specifying NODE_ENV which means both dependencies and devDependencies will be downloaded.

@GrinZero
Copy link
Contributor Author

You're right. I think I need to ask the questioner for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyRL TonyRL TonyRL left review comments

Assignees
No one assigned
Labels
Auto: Route Test Skipped PR involves no routes dependencies This PR involves changes to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

无法部署到Heroku
2 participants
@GrinZero @TonyRL