Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reco hit pos doesn't make sense for UV planes #94

Open
jdkio opened this issue Apr 18, 2024 · 2 comments
Open

Reco hit pos doesn't make sense for UV planes #94

jdkio opened this issue Apr 18, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right

Comments

@jdkio
Copy link
Contributor

jdkio commented Apr 18, 2024

Reco hit pos is storing x,y,z of hits, but x and y are u and v in some cases. So we need a better way to store things.

https://github.com/DUNE/dune-tms/blob/main/src/TMS_TreeWriter.h#L233

One option is to add another branch that tells you whether the hit was a X or U plane. Alternatively, we can explicitly save u and v hits in difference branches. So that x/y are -9999999 when u/v aren't and vice versa.

@jdkio jdkio added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right labels Apr 18, 2024
@AsaNehm
Copy link
Contributor

AsaNehm commented Apr 22, 2024

I tried to mitigate this problem already by storing the reconstructed x and y for u and v hit in reco hit pos (see Line 965ff in TMS_TreeWriter.cpp).
Do you think this helps for this?

@AsaNehm
Copy link
Contributor

AsaNehm commented Sep 9, 2024

@jdkio Is this still an issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants