Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing capital internal vars ($ARGS, $DEPS, etc) #586

Closed
DannyBen opened this issue Dec 27, 2024 · 4 comments
Closed

Consider allowing capital internal vars ($ARGS, $DEPS, etc) #586

DannyBen opened this issue Dec 27, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@DannyBen
Copy link
Owner

DannyBen commented Dec 27, 2024

Description

As discussed in #581, perhaps we can:

  1. Have a capital_global_vars setting
  2. When it is true, add a declare -gn ARGS=args DEPS=deps to enable both capital and lowercase vars

Another option is to have more flexibility with this kind of settings scheme:

args_varname=ARGS
deps_varname=DEPENDENCIES
other_args_varname=EXTRAS
@DannyBen
Copy link
Owner Author

DannyBen commented Dec 27, 2024

@meleu - this feature is implemented in #587 with a slightly different settings syntax.
I think this works well.

Next - I want to move all the declare from run() to initialize().

@DannyBen
Copy link
Owner Author

This is ready to be tested if interested.

@meleu
Copy link
Collaborator

meleu commented Dec 27, 2024

Yeah, it works beautifully!

@DannyBen
Copy link
Owner Author

Alright - so we can close this I guess, and I will probably release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants