From e05bb7e761e536712c9897f508ae21e7280e806c Mon Sep 17 00:00:00 2001 From: Andrey Date: Mon, 3 Jun 2024 12:01:45 +0200 Subject: [PATCH] use SecureRandom --- .../ci/contrib/ci_queue_minitest/instrumentation_spec.rb | 3 ++- spec/datadog/ci/contrib/ci_queue_rspec/instrumentation_spec.rb | 3 ++- spec/datadog/ci/contrib/cucumber/instrumentation_spec.rb | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/spec/datadog/ci/contrib/ci_queue_minitest/instrumentation_spec.rb b/spec/datadog/ci/contrib/ci_queue_minitest/instrumentation_spec.rb index 013aa2ca..0e4d67a8 100644 --- a/spec/datadog/ci/contrib/ci_queue_minitest/instrumentation_spec.rb +++ b/spec/datadog/ci/contrib/ci_queue_minitest/instrumentation_spec.rb @@ -1,5 +1,6 @@ require "minitest/queue/runner" require "fileutils" +require "securerandom" RSpec.describe "Minitest instrumentation with Shopify's ci-queue runner" do include_context "CI mode activated" do @@ -7,7 +8,7 @@ let(:integration_options) { {service_name: "ltest"} } end - let(:run_id) { rand(1..2**64 - 1) } + let(:run_id) { SecureRandom.random_number(2**64 - 1) } before do Minitest::Runnable.reset diff --git a/spec/datadog/ci/contrib/ci_queue_rspec/instrumentation_spec.rb b/spec/datadog/ci/contrib/ci_queue_rspec/instrumentation_spec.rb index 9e02bbf6..1da3a821 100644 --- a/spec/datadog/ci/contrib/ci_queue_rspec/instrumentation_spec.rb +++ b/spec/datadog/ci/contrib/ci_queue_rspec/instrumentation_spec.rb @@ -1,12 +1,13 @@ require "rspec/queue" require "fileutils" +require "securerandom" RSpec.describe "RSpec instrumentation with Shopify's ci-queue runner" do include_context "CI mode activated" do let(:integration_name) { :rspec } end - let(:run_id) { rand(1..2**64 - 1) } + let(:run_id) { SecureRandom.random_number(2**64 - 1) } let(:options) do RSpec::Core::ConfigurationOptions.new([ "-Ispec/datadog/ci/contrib/ci_queue_rspec/suite_under_test", diff --git a/spec/datadog/ci/contrib/cucumber/instrumentation_spec.rb b/spec/datadog/ci/contrib/cucumber/instrumentation_spec.rb index 3b23acdc..8ff61f98 100644 --- a/spec/datadog/ci/contrib/cucumber/instrumentation_spec.rb +++ b/spec/datadog/ci/contrib/cucumber/instrumentation_spec.rb @@ -1,6 +1,7 @@ require "stringio" require "fileutils" require "cucumber" +require "securerandom" RSpec.describe "Cucumber formatter" do let(:cucumber_features_root) { File.join(__dir__, "features") } @@ -22,7 +23,7 @@ let(:cucumber_8_or_above) { Gem::Version.new("8.0.0") <= Datadog::CI::Contrib::Cucumber::Integration.version } let(:cucumber_4_or_above) { Gem::Version.new("4.0.0") <= Datadog::CI::Contrib::Cucumber::Integration.version } - let(:run_id) { rand(1..2**64 - 1) } + let(:run_id) { SecureRandom.random_number(2**64 - 1) } let(:steps_file_definition_path) { "spec/datadog/ci/contrib/cucumber/features/step_definitions/steps.rb" } let(:steps_file_for_run_path) do "spec/datadog/ci/contrib/cucumber/features/step_definitions/steps_#{run_id}.rb"