From cbcac0240542f240ded079298f479b7a16b247b3 Mon Sep 17 00:00:00 2001 From: Andrey Date: Thu, 15 Aug 2024 09:45:38 +0200 Subject: [PATCH] make itr_enabled config parameter true by default --- lib/datadog/ci/configuration/settings.rb | 2 +- spec/datadog/ci/configuration/settings_spec.rb | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/datadog/ci/configuration/settings.rb b/lib/datadog/ci/configuration/settings.rb index c2addf33..0479d182 100644 --- a/lib/datadog/ci/configuration/settings.rb +++ b/lib/datadog/ci/configuration/settings.rb @@ -59,7 +59,7 @@ def self.add_settings!(base) option :itr_enabled do |o| o.type :bool o.env CI::Ext::Settings::ENV_ITR_ENABLED - o.default false + o.default true end option :git_metadata_upload_enabled do |o| diff --git a/spec/datadog/ci/configuration/settings_spec.rb b/spec/datadog/ci/configuration/settings_spec.rb index 960d2260..508985ed 100644 --- a/spec/datadog/ci/configuration/settings_spec.rb +++ b/spec/datadog/ci/configuration/settings_spec.rb @@ -222,7 +222,7 @@ def patcher describe "#itr_enabled" do subject(:itr_enabled) { settings.ci.itr_enabled } - it { is_expected.to be false } + it { is_expected.to be true } context "when #{Datadog::CI::Ext::Settings::ENV_ITR_ENABLED}" do around do |example| @@ -234,7 +234,7 @@ def patcher context "is not defined" do let(:enable) { nil } - it { is_expected.to be false } + it { is_expected.to be true } end context "is set to true" do @@ -253,10 +253,10 @@ def patcher describe "#itr_enabled=" do it "updates the #enabled setting" do - expect { settings.ci.itr_enabled = true } + expect { settings.ci.itr_enabled = false } .to change { settings.ci.itr_enabled } - .from(false) - .to(true) + .from(true) + .to(false) end end