Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to long PR titles #95

Open
Balastrong opened this issue Jan 21, 2024 · 9 comments
Open

Add tooltip to long PR titles #95

Balastrong opened this issue Jan 21, 2024 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Balastrong
Copy link
Member

Describe the feature

With #94 we fixed an issue on long titles, would be an additional feature to also have a tooltip when hovering on long/cut titles

It should be implemented because

No response

Additional context

No response

Would you like to work on this issue?

None

@Balastrong Balastrong added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 21, 2024
@CBID2
Copy link
Contributor

CBID2 commented Jan 29, 2024

I’ll work on this! :)

@Balastrong
Copy link
Member Author

Hey @CBID2, I see something similar is being worked on #101 (no worries, the PR was opened after your comment), would you mind doing the review of that PR?

@CBID2
Copy link
Contributor

CBID2 commented Jan 29, 2024

Hey @CBID2, I see something similar is being worked on #101 (no worries, the PR was opened after your comment), would you mind doing the review of that PR?

Sure

@Balastrong
Copy link
Member Author

Thank you :)

@CBID2
Copy link
Contributor

CBID2 commented Jan 29, 2024

Thank you :)

Can you approve the deployment in PR #101 @Balastrong? :) It was be easier for me to test this in the context of a website.

@Balastrong
Copy link
Member Author

Balastrong commented Jan 29, 2024

You're right, approved!

However let's see if it works... we had issues with login on preview builds (see #22).

The issue was on Vercel, now I switched to Nelify because Vercel didn't allow a free plan for organizations but the issue is probably still there.

If it doesn't work, you can checkout the PR branch locally :)

@CBID2
Copy link
Contributor

CBID2 commented Jan 29, 2024

You're right, approved!

However let's see if it works... we had issues with login on preview builds (see #22).

The issue was on Vercel, now I switched to Nelify because Vercel didn't allow a free plan for organizations but the issue is probably still there.

If it doesn't work, you can checkout the PR branch locally :)

Ok

@theflucs
Copy link
Contributor

theflucs commented Feb 7, 2024

I made it working using react-tooltip instead of daisy-ui's. It would be better to use the same tooltip library to maintain consistency in the codebase. @Balastrong what do you think?

@Balastrong
Copy link
Member Author

That's ok for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants