-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEO Review #15
Comments
OK, it looks like the issue in the second point about pages being rendered is that we're rendering them on the client. The same issue is present on the production academy site. If we can solve that on this new version with SSG/SSR rendering those pages, that would be great for SEO/UX/Performance, etc. |
@Markkos89 sitemap is looking niiiiiiiice, good work. Quick fix needed on this, there are double slashes appearing in some of the URLs in the sitemap.xml file here |
Alright, fixed it on #17 💪 |
amazing shipping @Markkos89 letsssgoooo |
Thanks kemps! 🙌 Can you check again if every page is being indexed now? 🤔 🙏 Thanks in advance! |
@kempsterrrr quick question, just to be sure, this is the desired favicon? 🤔 in case is not, can you please let me know which one? |
I think this is working ok, tools seem to be recognising the sitemap however as the pages are rendered with JavaScript the tool isn't crawling them because I need the very expensive paid version to do that. I think this is fine to ship as is and will make a note to look into it later this week when I have a little more time to see if can figure it out.,
these are the correct ones yes, although use the square logo for the favicon as they show as squares in the browser. |
@Markkos89 I noticed the 404 page wasn't working so added that as a todo item on here. How are you getting on with the other items? What else do you still need from me? |
I will write down the status of each remaining list item below @kempsterrrr SEO TODOs status:
Regarding indexing I'm waiting an update from you.
This is solved with the latest update of dynamic segment (dynamic routes)
This is something I leaving for later because it's something really small to do but if I change the database data will affect our production environment from
i will add it. |
Nice work! All I'm doing to check for the first point is running it through this tool which scrapes the site to check for SEO errors. Ideally we want to it pick up all the pages in the site. If the changes moved us away from client rendering they should show up in the crawl report. Only need paid version to crawl for client rendered pages which we're hoping to avoid. Ticked of the second one Makes sense re ULR changes, thanks for letting me know. Sounds good re 404 |
In support of getting app router version live asap, these bits (minus the dashes vs underscores) get us there. |
@kempsterrrr FYI I still have to create the content creators/authors/contributors registries in the database because it's going to be fetched dinamically. Can you help me gather all the information for all the contributors? we have some info in the contributors.ts file but maybe there is something left there so if you could gather all the info from the .mdx files that would be awesome mate 🙌 The goal is to populate this table: I left some notes in the code of where is going to be used |
@kempsterrrr PR #21 is merged. The 404 page was added. I ticked the 404 page item from the list. |
Excellent work, @Markkos89 ! I confirmed the pages are being crawled now 👏👏 Running the test did highlight a few other issues we need to work on for SEO, but they shouldn't be a blocker for getting this new version live, as these issues exist on the current site. I'll make a note to open another issue so we can track these as well; straightforward fixes could be excellent first issues for folks or easily added to another future PR. @wolovim, can you help gather the info for content creators, please? |
Awesome!! Thanks @kempsterrrr
@kempsterrrr @wolovim I will be working on this tomorrow 💪 |
WIP TODOs:
/
,/tracks
&/fundamentals
are being indexed when crawled. all pages need to be indexed. I'm unsure what is causing this yet but am asking an SEO friendArweave 101: Building Apps on Arweave | Developer DAO Academy
whereas this version, it isArweave 101: Building Apps on Arweave
-| Developer DAO Academy
is missing from the end. The inclusion of| Developer DAO Academy
should be programmatic and added to all pages automatically.-
"dashes" in between words not_
underscores, example for CLI Lesson using underscores -https://academy-t3-app-router.vercel.app/fundamentals/cli_lesson
** questions:**
The text was updated successfully, but these errors were encountered: