Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My commit to AutomobileGallery website #5

Closed
wants to merge 1 commit into from
Closed

My commit to AutomobileGallery website #5

wants to merge 1 commit into from

Conversation

dayanand-g
Copy link

Hey there,

Thank you so much for giving an opportunity to contribute towards to your project, so I hope am done with my work as much as I can by adding and editing a these following files :

AutomobileGallery

Simple Responsive Blog

Create a loading animation :

  1. Adding a Spinner-Wrapper file into it
  2. Adding a CSS code of spinner
  3. Linking a Script.js file into it
  4. performing a JavaScript operations

Creating a creative popups :

  1. Adding a popup HTML file to "Click through" button and "Launch" button in index.html file
  2. Adding a popup CSS file into main.css file
  3. Adding a popup JS file into script.js file

Creating a functional addons :

  1. Adding JavaScript API into js file but you have to specify the browser wanted.

I hope that am completed my work correctly as you mentioned in your repo, so please kindly merge my code into it.

Thank you.

@dayanand-g
Copy link
Author

Sir,

I hope that am done with my work as much as I can but the problem was project is not participating in Hacktoberfest.
It's showing like this project is not participating in the Hacktoberfest, So to resolve this issue please
kindly accept my request and add 'Hacktoberfest-accepted' label to my PR or else add 'Hacktoberfest'
label into your repo itself.
Please kindly do it sir, coz it is my first opensource contribution towards to the Haktoberfest.

Thank you.

@s-pratyush s-pratyush requested a review from Yadvendra7 October 19, 2021 18:27
@s-pratyush s-pratyush linked an issue Oct 19, 2021 that may be closed by this pull request
Copy link
Collaborator

@Yadvendra7 Yadvendra7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greatly done !
suggestion to use functions wherever necessary, to avoid heavy code.
efficiency in code is important.

@Yadvendra7
Copy link
Collaborator

There are some conflicts that need to be resolved , im creating another branch for you , pls send a pr again into that branch

@Yadvendra7 Yadvendra7 closed this Oct 20, 2021
@dayanand-g dayanand-g deleted the dayanand-pr-test5 branch October 21, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Javascript Functionalities
3 participants