Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to remove added entries from database #4

Open
Dilshan-H opened this issue Oct 15, 2022 · 8 comments
Open

Method to remove added entries from database #4

Dilshan-H opened this issue Oct 15, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs Waiting for contributions

Comments

@Dilshan-H
Copy link
Owner

Dilshan-H commented Oct 15, 2022

Currently, users can't remove added tracking email entries within the front-end. Instead users have to access the database and delete records separately.

A 'cross' or 'bin' icon can be shown inside the cards as below. (within the 'tracking list' dashboard)

164166439-acf8f86a-9dbd-48f1-af14-a5d3e7828fde.png

When clicked, a confirmation prompt can be shown to the user. And then safely delete that record from the database and refresh the listing page.

@Dilshan-H Dilshan-H added enhancement New feature or request good first issue Good for newcomers up for grabs Waiting for contributions labels Oct 15, 2022
@Jaskaran2
Copy link

Jaskaran2 commented Oct 15, 2022

Hi @Dilshan-H, may I work on it?

@YashPratap19
Copy link

Hi @Dilshan-H I would like to work on this project

@Dilshan-H
Copy link
Owner Author

Hi @Jaskaran2 👋
Sure! I'll assign it to you.

@Dilshan-H
Copy link
Owner Author

Hi @Dilshan-H I would like to work on this project

@YashPratap19 I have assigned @Jaskaran2 for this issue. Feel free to find any bugs, issues or provide new features by opening a new issue 🤗

@Jaskaran2
Copy link

Hi @Dilshan-H I would like to work on this project

@YashPratap19 I have assigned @Jaskaran2 for this issue. Feel free to find any bugs, issues or provide new features by opening a new issue 🤗

Thank you @Dilshan-H. I will try my best 😊.

@YashPratap19
Copy link

Hi @Dilshan-H I would like to work on this project

@YashPratap19 I have assigned @Jaskaran2 for this issue. Feel free to find any bugs, issues or provide new features by opening a new issue 🤗

Sure, I've just completed school and hoping this project will be my first open source contribution 🤞

@saroshfarhan
Copy link

Hi @Jaskaran2 @Dilshan-H,
I am new to flask and was doing changes locally(just for practice, I won't raise PR) and I had a doubt. While deleting the tracker from DB i also want to remove the hits from the link_hits table but doing so using a delete statement is throwing
RecursionError: maximum recursion depth exceeded in __instancecheck__
are you also facing this issue? Maybe I am doing something wrong here.
Below is the delete method that I have implemented:
Screenshot 2022-10-15 at 3 01 53 PM

Tried StackOverflow and various stuff but still wasn't able to get what I am doing wrong so thought of asking you all in the channel. If you can help me out, I will really be grateful.
Or you can tell me how you are planning on implementing this feature, it will really be a good learning opportunity for me.

@Jaskaran2
Copy link

Hi @Jaskaran2 @Dilshan-H, I am new to flask and was doing changes locally(just for practice, I won't raise PR) and I had a doubt. While deleting the tracker from DB i also want to remove the hits from the link_hits table but doing so using a delete statement is throwing RecursionError: maximum recursion depth exceeded in __instancecheck__ are you also facing this issue? Maybe I am doing something wrong here. Below is the delete method that I have implemented: Screenshot 2022-10-15 at 3 01 53 PM

Tried StackOverflow and various stuff but still wasn't able to get what I am doing wrong so thought of asking you all in the channel. If you can help me out, I will really be grateful. Or you can tell me how you are planning on implementing this feature, it will really be a good learning opportunity for me.

Hi @saroshfarhan , I have used flask for the first time today 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs Waiting for contributions
Projects
None yet
Development

No branches or pull requests

4 participants