Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data object collisions are possible; fix with renaming and catch errors #84

Open
briandominick opened this issue Jun 26, 2019 · 0 comments

Comments

@briandominick
Copy link
Collaborator

Now that #40 is implemented, object collisions are possible. I won't go into why I thought this would not be a problem, but it definitely is. One issue is multiple files of the same name being ingested from different paths, such as platform1/data/product.yml and `platform2/daata/product.yml.

- action: parse
  data:
    - file: platform/data/product.yml
      token: platform
    - file: client/data/product.yml
      token: client
  builds: ...

This really means adding the token: property to DataSource and making sure that class always processes data file ingest entries. (Not using object: as the property name because that namespace may be better used for ingesting data objects in this action, as in #83, in which case you might want to ingest an object: by name and rename it with token:.

This fix should also incorporate error handling for configured collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant