Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on conda-forge? #43

Closed
DocOtak opened this issue Mar 22, 2022 · 10 comments
Closed

Publish on conda-forge? #43

DocOtak opened this issue Mar 22, 2022 · 10 comments
Assignees

Comments

@DocOtak
Copy link
Owner

DocOtak commented Mar 22, 2022

While have never used it myself, I'm aware that conda-forge is a very popular place to get python packages.

It would probably be a good benefit to the community if we figure out how to get this package published on conda-forge.

@rcaneill
Copy link
Collaborator

I totally agree with you, I have never done it but it should not be too complicated

@rcaneill rcaneill self-assigned this Apr 26, 2022
@rcaneill
Copy link
Collaborator

I started to create the recipe for conda-forge, see https://github.com/rcaneill/staged-recipes/blob/gsw-xarray/recipes/gsw-xarray/meta.yaml

I'll try to comment on this issue with the steps needed to create the recipe (and maybe how to make it automatic via github actions when releasing?)

@DocOtak
Copy link
Owner Author

DocOtak commented Apr 27, 2022

Awesome, feel free to commit the master/main branch here if you feel things are ready (or if you need to experiment).

@rcaneill
Copy link
Collaborator

PR opened conda-forge/staged-recipes#18775

@DocOtak
Copy link
Owner Author

DocOtak commented May 4, 2022

Does the build on/for conda-forge fail without that "use deprecated out of tree build" option?

@rcaneill
Copy link
Collaborator

rcaneill commented May 4, 2022

I don't know, I commit the change Daniel Ching proposed, we'll see if this builds. I also asked him if the option is necessary

@rcaneill
Copy link
Collaborator

Does the build on/for conda-forge fail without that "use deprecated out of tree build" option?

Answer from the conda-forge team:

conda-forge/staged-recipes#18775 (comment)

Yes, this is the current recommendation for packages that use poetry for build until conda-build is patched. I believe that without this arg, poetry will try and create its own build environment which is not what we want / is redundant.
Related: conda-forge/conda-forge.github.io#1540

@DocOtak
Copy link
Owner Author

DocOtak commented May 13, 2022

@rcaneill I'm seeing some emails suggesting this is/has happened! Awesome stuff! Thanks so much!

@rcaneill
Copy link
Collaborator

It seems that there is still a little problem... I'll try to fix it / get some help

@rcaneill
Copy link
Collaborator

We are now on conda-forge!

https://anaconda.org/conda-forge/gsw-xarray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants