[1428] Event Timestamp Checker #2369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why pin the specific build? Just use the lastest GitHub available 3.11 version.
This was
linked to
issues
Feb 17, 2025
This command isn't needed and opens EDMC to a potential security bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a version of the Event Timestamp Check function used by @kenneaal in the FCMS plugin. This function checks the event timestamp is within 1 hour of the current time, and by default discards the timestamp entry if it is aged. The goal of this is to prevent duplicate reads from sending aged data to plugins. This can be disabled by a command-line argument.
This PR also includes a command-line argument (as requested by @Athanasius) to allow this check to be disabled by the user at runtime.
Removes an unneeded modification of the ExecutionPolicy in the Windows installer.
Finally, this also unpins the exact patch version of Python 3.11, to allow GitHub to use the most recent build available by default instead of mandating a version specifically.
Type of Change
New Feature Enhancement
How Tested
This code is already in use in the EDMC FCMS Plugin. 1
Notes
Resolves #1428