Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Powerplay 2.0 into state #2371

Open
dvdmuckle opened this issue Feb 20, 2025 · 1 comment · May be fixed by #2372
Open

Implement Powerplay 2.0 into state #2371

dvdmuckle opened this issue Feb 20, 2025 · 1 comment · May be fixed by #2372

Comments

@dvdmuckle
Copy link
Contributor

Describe the enhancement

Presently, it doesn't look like information on Powerplay 2.0 is available to plugins through the state interface. This information, such as what power you're pledged to and how many merits you have, is part of the Startup event and is emitted on logging into the game. Having this information would allow plugin developers to craft a couple plugins around Powerplay 2.0, the simplest of which could display how many merits you have at launch, so players can compare to how many merits they have in game (merit earning is not presently reported as an event sadly) when constructed reports on PP2.0 operations.

Expected behavior

Add to the state interface a subsection where one can query for Powerplay 2.0 information, as documented here: https://elite-journal.readthedocs.io/en/latest/Startup/#powerplay

Considered workarounds

I can't think of any workarounds to this at the moment, but I can take a crack at implementing this and submitting a PR.

Additional context

If it wasn't obvious, I'm looking to craft a plugin that will report the number of merits one has when they start the game. It doesn't look like that's currently possible with EDMC.

@dvdmuckle dvdmuckle linked a pull request Feb 21, 2025 that will close this issue
@dvdmuckle
Copy link
Contributor Author

I created a PR to address this, I'm fairly certain I got everything covered, including updating Inara.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant