Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Server links #179

Open
Askarionn opened this issue Dec 22, 2024 · 4 comments
Open

[BUG] Server links #179

Askarionn opened this issue Dec 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Askarionn
Copy link

Describe the bug
When using VelocityCTD and LimboAPI, the Server Links feature from VelocityCTD it's not working

To Reproduce
Steps to reproduce the behavior:

  1. Install LimboAPI
  2. Install https://github.com/GemstoneGG/Velocity-CTD
  3. See error

Expected behavior
The server links shoudl work

Screenshots

Server Info (please complete the following information):

Additional context

@Askarionn Askarionn added the bug Something isn't working label Dec 22, 2024
@mdxd44
Copy link
Member

mdxd44 commented Dec 23, 2024

I can't even imagine what "Server Links" means, I'll assume that this is not a LimboAPI problem

@mdxd44 mdxd44 closed this as completed Dec 23, 2024
@Askarionn
Copy link
Author

Server Links is a Minecraft feature added in 1.21 or 1.21.1: https://www.youtube.com/watch?v=jycB7aWd_2I
When using Velocity-CTD without LimboAPI, the server links are working, but using LimboAPI they're not working anymore, so I'm assuming it's because of LimboAPI, right?

@UserNugget
Copy link
Member

Velocity-CTD uses AuthSessionHandler to send Server Links to the client which LimboAPI almost completly replace, but it 'should be easy to fix' tho.

@UserNugget UserNugget reopened this Dec 23, 2024
@hevav
Copy link
Member

hevav commented Dec 23, 2024

I think that such functionality should be implemented by a plugin in the PostLoginEvent, instead of direct handling in internal proxy session handlers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants