Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Tweakwise hits the feed URL a redirect might take place #42

Open
6 tasks
dverkade opened this issue Apr 9, 2024 · 6 comments
Open
6 tasks

When Tweakwise hits the feed URL a redirect might take place #42

dverkade opened this issue Apr 9, 2024 · 6 comments
Assignees

Comments

@dverkade
Copy link

dverkade commented Apr 9, 2024

Issue Brief

When Tweakwise hits the feed URL a redirect might take place, causing invalid feeds to be retrieved.

Environment

  • PHP Version: 8.1
  • Magento Version: 2.4.6-p4
  • Magento Enterprise: No
  • Tweakwise Export Version:
  • Magento Deploy Mode: production

Steps to reproduce

  1. Have a storeview on example.com and a separate backoffice URL, like backoffice.example.com
  2. example.com runs on webserver 1 and backoffice.example.com runs on webserver 2
  3. Crons only run on webserver 2 / the backoffice server.
  4. Feeds gets generated on webserver 2.

Actual result

  1. When Tweakwise hits the feed URL it will redirect / fetch the feed from the store domain URL. I.e. https://backoffice.examaple.com/tweakwise/feed/export/key/1234 will get the feed from https://www.example.com/tweakwise/feed/export/key/4576 which might get this from another webserver which does not have (the latest ) feed.

Expected result

List the expected results as a bullet list of expectations

  • Do not redirect to store URL and fetch from the admin / backoffice domain directly.
@ah-net
Copy link
Collaborator

ah-net commented Apr 18, 2024

@dverkade nvm, misunderstood the issue. I'll look into this and see if we can find an solution for this

@ah-net ah-net self-assigned this May 21, 2024
@ah-net
Copy link
Collaborator

ah-net commented Jun 28, 2024

@dverkade When you login to the admin is the admin url backoffice.example.com or do you have an custom path behind that? backoffice.exmple.com/admin_path

@dverkade
Copy link
Author

@ah-net, yes it has a custom path for security purposes as the default path can easily be guessed

@ah-net
Copy link
Collaborator

ah-net commented Jun 28, 2024

@dverkade And what happens if you go to backoffice.example.com without the admin path? Because for me it redirects to an store. So that means we don't do the redirect, magento does it, because backoffice.example.com is not an valid store/url
I'm not sure if this is something we can/should fix in that case.

@dverkade
Copy link
Author

@ah-net, yes it's a valid store as backoffice.example.com is set on the default scope and the individual stores have other base URL's set in the store configuration.

@ah-net
Copy link
Collaborator

ah-net commented Jun 28, 2024

@dverkade That explains it. Thx. I will see if i can reproduce that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants